Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct calls of getRollData in Actor5e to the system model #2698

Closed
krbz999 opened this issue Dec 30, 2023 · 1 comment
Closed

Direct calls of getRollData in Actor5e to the system model #2698

krbz999 opened this issue Dec 30, 2023 · 1 comment
Assignees
@krbz999
Labels
api
Milestone
D&D5E 3.0.0

Comments

@krbz999
Copy link
Contributor

krbz999 commented Dec 30, 2023 •
edited
Loading

Currently we just skip over group actor specifically in Actor5e, but this fails for any other actor types added by modules.

If getRollData instead returned system.getRollData each added actor type could change behaviour any way it pleases.

Currently a new actor type is forced to have system.attributes.prof, otherwise they cannot even render owned items' sheets.

In fact, a whole slew of methods fail if an added actor type does not have system.attributes.
@Fyorl Fyorl added the api label Dec 30, 2023
@Fyorl Fyorl added this to the D&D5E 2.5.0 milestone Dec 30, 2023
krbz999 added a commit to krbz999/dnd5e that referenced this issue Dec 30, 2023
@krbz999
[foundryvtt#2698] Move getRollData to system
ead631e
@krbz999 krbz999 mentioned this issue Dec 31, 2023
Merged
@JPMeehan
Copy link

Would appreciate this for sure, it's blocking me using items in my knw-actors module.

@JPMeehan JPMeehan mentioned this issue Jan 14, 2024
Closed
arbron added a commit that referenced this issue Jan 18, 2024
@arbron
Merge pull request #2701 from krbz999/Branch-Out-getRollData
16fb82f 
[#2698] Move getRollData to system models
@arbron arbron closed this as completed Jan 18, 2024
Fyorl pushed a commit that referenced this issue Jan 31, 2024
@arbron
[#2698] Move getRollData for items into system model
3f4df70
Fyorl pushed a commit that referenced this issue Jan 31, 2024
@arbron
[#2698] Add derived item data to item's roll data
43adc1c
Fyorl pushed a commit that referenced this issue Jan 31, 2024
@arbron
Merge pull request #147 from foundryvtt/item-roll-data
7bd2e3c 
[#2698] Move getRollData for items into system model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krbz999 krbz999

Labels
api
Projects
None yet
Milestone
D&D5E 3.0.0
Development

No branches or pull requests
4 participants
@Fyorl @JPMeehan @arbron @krbz999