Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item5e#deleteDialog fails for module actor types without a system.details property. #2947

Closed
krbz999 opened this issue Feb 7, 2024 · 0 comments
Closed

Item5e#deleteDialog fails for module actor types without a system.details property. #2947

krbz999 opened this issue Feb 7, 2024 · 0 comments
Assignees
@arbron
Labels
bug Functionality which is not working as intended
Milestone
D&D5E 3.0.2

Comments

@krbz999
Copy link
Contributor

krbz999 commented Feb 7, 2024

image

System has a check only for the actor type being group. There should probably more simply be a check for "details" in this.actor.system.
@arbron arbron added the bug Functionality which is not working as intended label Feb 7, 2024
@arbron arbron added this to the D&D5E 3.0.2 milestone Feb 7, 2024
@arbron arbron self-assigned this Feb 9, 2024
arbron added a commit to arbron/dnd5e that referenced this issue Feb 9, 2024
@arbron
[foundryvtt#2947] Add metadata.supportsAdvancement, fix issue with de…
0eb9133 
…leteDialog failing

Move singleton property from `SystemDataModel#metadata` to `ItemDataModel#metadata`
and reworked data model metadata as frozen object with proper default values.

Added `supportsAdvancement` metadata option to `ActorDataModel#metadata` to indicate
actor types that can have advancement applied. Using the new metadata property in
`deleteDialog` should ensure no errors for module-provided actor types.
arbron added a commit to arbron/dnd5e that referenced this issue Feb 9, 2024
@arbron
[foundryvtt#2947] Add metadata.supportsAdvancement, fix issue with de…
355ed06 
…leteDialog failing

Move singleton property from `SystemDataModel#metadata` to `ItemDataModel#metadata`
and reworked data model metadata as frozen object with proper default values.

Added `supportsAdvancement` metadata option to `ActorDataModel#metadata` to indicate
actor types that can have advancement applied. Using the new metadata property in
`deleteDialog` should ensure no errors for module-provided actor types.
arbron added a commit to arbron/dnd5e that referenced this issue Feb 12, 2024
@arbron
[foundryvtt#2947] Resolve singleton TODO, don't freeze abstract metadata
1ec7efc
arbron added a commit that referenced this issue Feb 12, 2024
@arbron
Merge pull request #2997 from arbron/supports-advancement
d75c510 
[#2947] Add metadata.supportsAdvancement, fix issue with deleteDialog failing
@arbron arbron closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
bug Functionality which is not working as intended
Projects
None yet
Milestone
D&D5E 3.0.2
Development

No branches or pull requests
2 participants
@arbron @krbz999