Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend automation of Volley trait to NPCs #7219

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

stwlam
Copy link
Collaborator

@stwlam stwlam commented Mar 31, 2023

Closes #7211

Refactored to move common handling of certain traits to a base static class and made the PC version subclass it

@CarlosFdez
Copy link
Collaborator

CarlosFdez commented Apr 3, 2023

Might need to check for attack roll check type specifically, since you can do athletics checks with weapons (at least not implemented in core, though I think some modules and macros make that possible).

EDIT: agile works with weapons fsr, but not sweep for example

@CarlosFdez
Copy link
Collaborator

On second glance, I think the only exception is sweep. The rest seem to be restricted to attacks in general, not just attack rolls, but sweep and finesse specifies attack roll.

@stwlam
Copy link
Collaborator Author

stwlam commented Apr 3, 2023

I'm not sure what you mean. These are only used for generating strikes.

@CarlosFdez
Copy link
Collaborator

getCheckRollContext() was expanded for all checks was it not?

@CarlosFdez
Copy link
Collaborator

Ok no I got, it was expanded to support spell attack rolls, but not all checks (despite its name).

@stwlam
Copy link
Collaborator Author

stwlam commented Apr 3, 2023

That's a different PR: #7198

@stwlam stwlam merged commit f0595a2 into foundryvtt:master Apr 3, 2023
@stwlam stwlam deleted the npc-volley branch April 3, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPC volley automation not applying
2 participants