Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create kingmaker features compendium #8554

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

CarlosFdez
Copy link
Collaborator

Hidden from production builds

@CarlosFdez CarlosFdez added the pr: data entry New actor and item data label Jul 3, 2023
@CarlosFdez
Copy link
Collaborator Author

I ran these through the data entry script, with a minor tweak to handle "basic kingdom checks" since those are just kingmaker checks against a control dc. Let me know if additional changes are required like converting that unicode - to an actual -.

@stwlam
Copy link
Collaborator

stwlam commented Jul 5, 2023

These look to all be (proper) actions. Calling them features is confusing.

@CarlosFdez
Copy link
Collaborator Author

CarlosFdez commented Jul 5, 2023

The compendium will also include kingdom feats, kingdom levelup features, and I'm assuming based on @silvative's branch, army actions?

EDIT: I plan to introduce folders soon, I wasn't aware the export script handled those.
EDIT2: I don't mind picking a more general name for all these disparate things, kingmaker-features is just what was brought up in the discord.

@CarlosFdez CarlosFdez force-pushed the kingdom-features-compendium branch 2 times, most recently from 40998f5 to bc0c99f Compare July 6, 2023 03:58
@CarlosFdez
Copy link
Collaborator Author

I need to figure out why extract packs crashes when there are folders at some point, but stubbed out kingdom features and feats into new folders. Cora's army branch as an army folder going into kingmaker-features as well, so that can probably be rebased onto this one.

@CarlosFdez CarlosFdez marked this pull request as draft July 6, 2023 07:58
@CarlosFdez CarlosFdez marked this pull request as ready for review July 17, 2023 01:11
@CarlosFdez
Copy link
Collaborator Author

This should be ready now. Its the new campaignFeature type and has more items in there now. Still hidden in production builds.

@stwlam stwlam merged commit f2d7919 into foundryvtt:master Jul 19, 2023
@CarlosFdez CarlosFdez deleted the kingdom-features-compendium branch July 19, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: data entry New actor and item data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants