Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private repository is not matched #241

Closed
megri opened this issue Dec 22, 2016 · 8 comments
Closed

Private repository is not matched #241

megri opened this issue Dec 22, 2016 · 8 comments

Comments

@megri
Copy link

megri commented Dec 22, 2016

When I run g8 myorganization/myprivaterepo.g8 I get an unhandled exception:

org.eclipse.jgit.api.errors.TransportException: git://github.com/myorganization/myprivaterepo.g8.git:
  Repository not found.

I have a potential fix but I'm not sure how to test this locally or write a test case for it: megri@c7750ee

How do I proceed?

@eed3si9n
Copy link
Member

eed3si9n commented Jan 6, 2017

You can publish Giter8 locally with a snapshot version and install it via Conscript.

@analytically
Copy link

analytically commented Jan 10, 2017

Hi @eed3si9n, mind explaining this a bit more?
We're running into this issue as well using sbt new ..., thanks!

@patrick-premont
Copy link

I've tested the proposed fix above, and it works for me but only if the condition if e.getMessage == "Repository not found." is removed. I think it is best to omit the message check.

So the fix simply changes the matched exception type, from org.eclipse.jgit.api.errors.JGitInternalException toorg.eclipse.jgit.api.errors.TransportException.

I have not encountered an occurence of an org.eclipse.jgit.api.errors.JGitInternalException, but that check might have been introduced for a reason, so it may be worth accepting both types of exception?

@eed3si9n
Copy link
Member

I'm guessing that at some point JGit changed the type of the exception, so I'm ok with just substituting JGitInternalException with TransportException.

@patrick-premont
Copy link

Make sense. Submitted PR #248

@eed3si9n
Copy link
Member

Thanks!

For others following this case, this issue was expedited via the Lightbend subscription.

@megri
Copy link
Author

megri commented Jan 12, 2017 via email

@eed3si9n
Copy link
Member

Fixed by #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants