Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data should be an object error if slic-watch config is missing #63

Closed
eoinsha opened this issue Sep 5, 2021 · 0 comments · Fixed by #64
Closed

data should be an object error if slic-watch config is missing #63

eoinsha opened this issue Sep 5, 2021 · 0 comments · Fixed by #64
Assignees
Labels
bug Something isn't working

Comments

@eoinsha
Copy link
Contributor

eoinsha commented Sep 5, 2021

Describe the bug
When the plugin is installed and added to plugins but no configuration is present, the following error occurs.


 Serverless Error ----------------------------------------

  SLIC Watch configuration is invalid: data should be object

This is not really clear

To Reproduce
Steps to reproduce the behavior:

  1. npm install serverless-slic-watch-plugin
  2. Add serverless-slic-watch-plugin to plugins section

Expected behavior
The process should proceed with a default configuration for SLIC Watch or a clear error should convey that the configuration is missing.

Screenshots, Input Files and Logs

@eoinsha eoinsha added the bug Something isn't working label Sep 5, 2021
@eoinsha eoinsha self-assigned this Sep 5, 2021
eoinsha added a commit that referenced this issue Sep 5, 2021
- Fixes #63
- Reflects documented behaviour, that plugin config is optional
eoinsha added a commit that referenced this issue Sep 11, 2021
- Fixes #63
- Reflects documented behaviour, that plugin config is optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant