Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional sns topic #57

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Optional sns topic #57

merged 1 commit into from
Jun 25, 2021

Conversation

eoinsha
Copy link
Contributor

@eoinsha eoinsha commented Jun 25, 2021

Making topicArn mandatory wasn't necessary. Alarms don't require it, so why should we? It is friction for people who just want to try SLIC Watch out.
This change makes topicArn optional, allowing users to include or exclude it. They can still view alarms via the AWS Console, etc.

@eoinsha eoinsha requested a review from lmammino June 25, 2021 12:25
@coveralls
Copy link

coveralls commented Jun 25, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling adcd34a on optional-sns-topic into 9073cb2 on main.

lmammino
lmammino approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@lmammino lmammino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome feature and the implementation looks really clean!

Great work! 💯

@eoinsha eoinsha merged commit f7a9ac0 into main Jun 25, 2021
@eoinsha eoinsha deleted the optional-sns-topic branch June 25, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmammino lmammino lmammino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eoinsha @coveralls @lmammino