-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SNS alarms and dashboard #83
Conversation
- Without adding threshold in the resource EvaluationPeriods outputs String by default - Threshold and EvaluationPeriods have to output integer in that case
- Doing integration test with real resources by adding https endpoint and creating lambda function to handle confirmSubscription for SNS topic
serverless-test-project/package.json
Outdated
"gitHead": "c4300240f9e854c4eb1c5503b839882ff0cd1cae" | ||
"gitHead": "c4300240f9e854c4eb1c5503b839882ff0cd1cae", | ||
"dependencies": { | ||
"https": "^1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js has a built-in https
module, so I don't think we need to add an NPM module. Does it add anything?
I'd like to suggest replacing this with axios
in any case and changing the handler to use async
/await
.
- Remove usage of sns-validator as it was overkill
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM!
Description
Add support for SNS alarms and dashboard for the metrics are
Motivation and Context
NumberOfNotificationsFilteredOut-InvalidAttributes - This metric keeps track of messages that were filtered out because they carried invalid or malformed attributes and, thus, didn’t match the subscription filter policy.
NumberOfNotificationsFailed – This last metric tracks all the messages that failed to be delivered to subscribing endpoints, regardless of whether a filter policy had been set for the endpoint. This metric is emitted after the message delivery retry policy is exhausted, and SNS stops attempting to deliver the message. At that moment, the subscribing endpoint is likely no longer reachable. For example, the subscribing SQS queue or Lambda function has been deleted by its owner. You may want to closely monitor this metric to address message delivery issues quickly.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: