Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS SAM support #91

Merged
merged 64 commits into from
Oct 10, 2022
Merged

AWS SAM support #91

merged 64 commits into from
Oct 10, 2022

Conversation

ssamueluk
Copy link
Contributor

@ssamueluk ssamueluk commented Aug 17, 2022 •
edited by eoinsha
Loading

Description

Updated Serverless plugin project to use shared Core library
Added CF Macro SAM and Serverless projects (will delete one after the review)
Added SAM and CDK Test projects

Motivation and Context

To add SLIC Watch monitoring to SAM and CDK Stacks in addition to Serverless stacks

Full Release Checklist

  • Update the links in the slic-watch-core README to point to the main branch
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ssamueluk ssamueluk requested a review from eoinsha August 17, 2022 14:51
@coveralls
Copy link

coveralls commented Aug 17, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 32f1c39 on slic-watch-sam-support into 4590498 on main.

@eoinsha eoinsha changed the title Slic watch sam support AWS SAM support Aug 18, 2022
eoinsha
eoinsha requested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@eoinsha eoinsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great work and it's nice to be so close to having full SAM support!
Before we merge, we will need to update the top-level README with full instructions on usage for SAM.

core/alarms-lambda.js Outdated Show resolved Hide resolved
serverless-plugin/tests/alarms-api-gateway.test.js Outdated Show resolved Hide resolved
cf-macro/package.json Outdated Show resolved Hide resolved
cdk-test-project/README.md Outdated Show resolved Hide resolved
cf-macro-serverless/serverless.yml Outdated Show resolved Hide resolved
@eoinsha eoinsha requested a review from lmammino August 18, 2022 11:42
eoinsha
eoinsha requested changes Aug 26, 2022
View reviewed changes
cf-macro/tests/event.json Outdated Show resolved Hide resolved
cf-macro/tests/index.test.js Show resolved Hide resolved
cf-macro/tests/index.test.js Show resolved Hide resolved
cf-macro/tests/index.test.js Outdated Show resolved Hide resolved
core/alarms-lambda.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 26, 2022
View reviewed changes
cf-macro/index.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 26, 2022
View reviewed changes
cf-macro/index.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 26, 2022
View reviewed changes
cf-macro/index.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 26, 2022
View reviewed changes
cf-macro/index.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 28, 2022
View reviewed changes
cf-macro/index.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 28, 2022
View reviewed changes
core/alarms-lambda.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 28, 2022
View reviewed changes
core/alarms-lambda.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 28, 2022
View reviewed changes
core/alarms-lambda.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 28, 2022
View reviewed changes
core/alarms-lambda.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 28, 2022
View reviewed changes
core/alarms-lambda.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 28, 2022
View reviewed changes
core/alarms-lambda.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 28, 2022
View reviewed changes
core/util.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 28, 2022
View reviewed changes
core/util.js Outdated Show resolved Hide resolved
lmammino
lmammino reviewed Aug 28, 2022
View reviewed changes
core/util.js Outdated Show resolved Hide resolved
lmammino
lmammino approved these changes Aug 28, 2022
View reviewed changes
Copy link
Contributor

@lmammino lmammino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few more comments around, but all over this is excellent work and I am looking forward to seeing SLIC Watch officially supporting CloudFormation, SAM (and hopefully even CDK)!

Great work 👏🏽 🎉

direnakkoc
direnakkoc requested changes Oct 6, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
eoinsha
eoinsha approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@eoinsha eoinsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read to merge! Thank you @ssamueluk 🎉

@eoinsha eoinsha merged commit df5ced5 into main Oct 10, 2022
@eoinsha eoinsha deleted the slic-watch-sam-support branch October 10, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmammino lmammino lmammino approved these changes

@eoinsha eoinsha eoinsha approved these changes

@direnakkoc direnakkoc direnakkoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ssamueluk @coveralls @lmammino @eoinsha @direnakkoc