This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 70
Changes for adding babel, removing global JS #163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@evanmwillhite I'm getting this error on
|
I'm also curious about the repercussions of releasing a new emulsify-gulp. Is that being versioned now? Or will the update break backward compatibility for anyone? |
I think I know why I'm getting the uglify error. Seeing if I can fix that now. (TL;DR: Used an existing install, so the yarn.lock was already created) |
ModulesUnraveled
added
Status: Passes functional review
and removed
Status: In Progress
labels
Oct 18, 2017
W00t! Works great! |
ModulesUnraveled
approved these changes
Oct 18, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ES6 support (Babel)
Companion PR for Emulsify Gulp's fourkitchens/emulsify-gulp#64
Features:
dist/02-molecules/accordion-item/accordion-item.js
To test:
composer install
"emulsify-gulp": "fourkitchens/emulsify-gulp#add-babel",
yarn install
yarn start
Post-merge