Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Replacing <button> element with <a href> whenever there's a link #264

Merged
merged 3 commits into from
Jun 28, 2018
Merged

Replacing <button> element with <a href> whenever there's a link #264

merged 3 commits into from
Jun 28, 2018

Conversation

shaal
Copy link
Contributor

@shaal shaal commented Jun 28, 2018

Resolving #263.

If there is a link inside the button, it switches it into element, because it only needs to look like a button but behave like a link.
I added twig brackets to print partial elements {{ "<a" }}, because it seemed a "cleaner" way of doing it, but the same result can be achieved without these brackets.

@evanmwillhite evanmwillhite self-requested a review June 28, 2018 02:54
Copy link
Contributor

@evanmwillhite evanmwillhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already have a link component, let's get rid of the <a> and href pieces (and the if/else statements) altogether. href being in here was probably leftover from before we split those up or something and you're right, we don't need it. If we need to attach JS events, we can add data attributes (or whatever we want) easily enough per project.

@shaal
Copy link
Contributor Author

shaal commented Jun 28, 2018

Copy link
Contributor

@evanmwillhite evanmwillhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! And thanks for all your work and feedback with the project lately. We appreciate it!

@evanmwillhite evanmwillhite merged commit e8b81a9 into fourkitchens:develop Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants