Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

291: move icon inside navigation #313

Merged
merged 1 commit into from Dec 15, 2018
Merged

291: move icon inside navigation #313

merged 1 commit into from Dec 15, 2018

Conversation

evanmwillhite
Copy link
Contributor

@evanmwillhite evanmwillhite commented Dec 11, 2018 •
edited

#291: Move icon inside navigation, change styles accordingly (accessibility improvement)

Description:

  • Move icon per the recommendations here (also show nav)
  • Also moves some styling to the correct place (fixing the position and giving it a 100% height) that was on the wrong element.

To Test:

  • Verify the Main Menu still functions as it should

mikeethedude
mikeethedude approved these changes Dec 15, 2018
View reviewed changes
Copy link
Collaborator

@mikeethedude mikeethedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested in a multiple browsers as well.

@mikeethedude mikeethedude merged commit 82c50bf into develop Dec 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikeethedude mikeethedude mikeethedude approved these changes

Assignees
No one assigned
Labels
Priority: Low Status: Review Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evanmwillhite @mikeethedude