Add support for at.exe .job files in scheduled tasks #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement binary .job file parsing - Ensure consistency with XML task files by using the same record fields - Extend and enhance tests - Include missing docstrings and type hints for better documentation This change allows the tasks parser to handle .job files, providing compatibility with at.exe scheduled tasks.
Wouter-Jansen
requested review from
Schamper,
Miauwkeru,
pyrco and
cecinestpasunepipe
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 68.61% 68.81% +0.19%
==========================================
Files 222 225 +3
Lines 17036 17147 +111
==========================================
+ Hits 11690 11800 +110
- Misses 5346 5347 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 31 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Schamper
previously requested changes
May 11, 2023
- Fixed docstrings - Better var naming - Identing - Fix struct field types
pyrco
requested changes
May 12, 2023
pyrco
reviewed
May 12, 2023
Miauwkeru
requested changes
May 12, 2023
- Split tasks.py in three files and classes - Refactor to reduce code duplication - Various improvements
- Add more records to be tested - Add more fields to be tested - Improve test file with more fields used
…of github.com:fox-it/dissect.target into DIS-1558_Add_at.exe_job_files_scheduled_tasks_support
Miauwkeru
requested changes
May 22, 2023
cecinestpasunepipe
previously requested changes
May 22, 2023
- Improve handling of padding - Fix delay bug in old code - Improve naming consistency - Improve exeption handling - Improve tests
pyrco
requested changes
May 23, 2023
- Move record descriptors to separate file - Implement some improvements - Fix some bugs
…of github.com:fox-it/dissect.target into DIS-1558_Add_at.exe_job_files_scheduled_tasks_support
That may be even cleaner indeed. I'd keep |
|
I'd remove the |
pyrco
requested changes
May 31, 2023
…of github.com:fox-it/dissect.target into DIS-1558_Add_at.exe_job_files_scheduled_tasks_support
pyrco
approved these changes
May 31, 2023
Wouter-Jansen
dismissed stale reviews from Miauwkeru, cecinestpasunepipe, and Schamper
Reviewed by @pyrco
Wouter-Jansen
deleted the
DIS-1558_Add_at.exe_job_files_scheduled_tasks_support
branch
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DIS-1558)