Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user enter it if no PIN is provided #7

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

xwjdsh
Copy link
Contributor

@xwjdsh xwjdsh commented Nov 15, 2022

I also do a little bit of change to the transfer command, just put the logic of displaying the QRcode before reading PIN.

Fixes #6

@xwjdsh xwjdsh requested a review from yiplee November 15, 2022 10:42
@yiplee yiplee merged commit 6d05634 into master Nov 15, 2022
@yiplee yiplee deleted the feat/enter-pin-if-not-set branch November 15, 2022 14:16
@Halimao
Copy link

Halimao commented Nov 16, 2022

user create --pin missing to hide password input and still return err "execute failed: flag needs an argument: --pin"

@xwjdsh
Copy link
Contributor Author

xwjdsh commented Nov 16, 2022

Do not pass --pin and then it'll randomly assign a PIN value, this is a different case, the pin will assign to the new user. If we do update here, then it will break the behavior of "random PIN", although we can add a flag to let the user input a PIN specifically, it's unnecessary I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feathure] Hide pin input support
3 participants