This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
Reserve and limit overhaul #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manifest
reviewed
Aug 4, 2020
src/db/janus_backend.rs
Outdated
| LEFT JOIN room AS r2 | ||
| ON 1 = 1 | ||
| WHERE r2.id = $1 | ||
| AND COALESCE(jb.subscribers_limit, 2147483647) - COALESCE(sub.taken, 0) > COALESCE(r2.reserve, 0) |
There was a problem hiding this comment.
Shouldn't we change subscribers_limit field to reserve?
There was a problem hiding this comment.
It seems as we just subtract the largest room capacity from the capacity of its janus host, when we must subtract the sum of capacities over all rooms that share the same janus host.
There was a problem hiding this comment.
Shouldn't we change subscribers_limit field to reserve?
For janus_backend no because it's actually a limit.
There was a problem hiding this comment.
It seems as we just subtract the largest room capacity from the capacity of its janus host, when we must subtract the sum of capacities over all rooms that share the same janus host.
Good point. Fixed.
khodzha
reviewed
Aug 4, 2020
feymartynov
force-pushed
the
feature/ULMS-687
branch
from
9e8d61f
to
13912ff
Compare
feymartynov
force-pushed
the
feature/ULMS-687
branch
from
13912ff
to
3b1edf0
Compare
khodzha
approved these changes
Aug 4, 2020
manifest
approved these changes
Aug 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.