This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
Add label to message.broadcast and metrics #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manifest
approved these changes
Sep 7, 2020
khodzha
suggested changes
Sep 7, 2020
| Self { tx, back_rx } | ||
| } | ||
|
|
||
| pub(crate) fn collect(&self, key: impl Into<String>, value: usize) { |
There was a problem hiding this comment.
тут нужны этот impl и value?
There was a problem hiding this comment.
В принципе можно и без них, т.к. это сейчас в одном месте используется, но это типа, чтобы не зашиваться на конкретный кейс и переиспользовать потом ещё где-то.
feymartynov
force-pushed
the
feature/ULMS-740
branch
from
6f25917
to
7cb12fd
Compare
khodzha
approved these changes
Sep 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.