This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
Send rtc_stream.update with closing time when the backend goes offline #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khodzha
approved these changes
Sep 24, 2020
|
Why don't use relation between backend and related streams to delete them automatically? Why do we close (changing their time) these streams manually? |
|
It does delete them by foreign key. That's why there's no point of updating the stream in the DB since it's gonna be deleted in later in the same transaction. It's enough just to set the closing date in the transient object to send within the event. |
manifest
approved these changes
Sep 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.