Skip to content

Commit

Permalink
add frame_id to RawImage, CompressedImage, and CameraCalibration (#61)
Browse files Browse the repository at this point in the history
**Public-Facing Changes**
Added `frame_id` to RawImage, CompressedImage, and CameraCalibration

**Description**
Closes #59 
Unblocks foxglove/studio#4323
  • Loading branch information
jtbandes committed Sep 7, 2022
1 parent 8301af4 commit b6b7350
Show file tree
Hide file tree
Showing 27 changed files with 195 additions and 36 deletions.
3 changes: 3 additions & 0 deletions ros_foxglove_msgs/ros1/CameraCalibration.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ros_foxglove_msgs/ros1/CompressedImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ros_foxglove_msgs/ros1/RawImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ros_foxglove_msgs/ros2/CameraCalibration.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ros_foxglove_msgs/ros2/CompressedImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ros_foxglove_msgs/ros2/RawImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions schemas/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions schemas/jsonschema/CameraCalibration.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions schemas/jsonschema/CompressedImage.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions schemas/jsonschema/RawImage.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/proto/foxglove/CameraCalibration.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/proto/foxglove/CompressedImage.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/proto/foxglove/RawImage.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/ros1/CameraCalibration.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/ros1/CompressedImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/ros1/RawImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/ros2/CameraCalibration.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/ros2/CompressedImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/ros2/RawImage.msg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/typescript/CameraCalibration.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/typescript/CompressedImage.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions schemas/typescript/RawImage.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 22 additions & 22 deletions src/generateProto.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,75 +37,75 @@ describe("generateProto", () => {
bool field_boolean = 3;
// bytes field
bytes field_bytes = 4;
bytes field_bytes = 5;
// float64 field
double field_float64 = 5;
double field_float64 = 6;
// uint32 field
fixed32 field_uint32 = 6;
fixed32 field_uint32 = 7;
// string field
string field_string = 7;
string field_string = 8;
// duration array field
repeated google.protobuf.Duration field_duration_array = 8;
repeated google.protobuf.Duration field_duration_array = 9;
// time array field
repeated google.protobuf.Timestamp field_time_array = 9;
repeated google.protobuf.Timestamp field_time_array = 10;
// boolean array field
repeated bool field_boolean_array = 10;
repeated bool field_boolean_array = 11;
// bytes array field
repeated bytes field_bytes_array = 11;
repeated bytes field_bytes_array = 12;
// float64 array field
repeated double field_float64_array = 12;
repeated double field_float64_array = 13;
// uint32 array field
repeated fixed32 field_uint32_array = 13;
repeated fixed32 field_uint32_array = 14;
// string array field
repeated string field_string_array = 14;
repeated string field_string_array = 15;
// duration fixed-length array field
repeated google.protobuf.Duration field_duration_fixed_array = 15; // length 3
repeated google.protobuf.Duration field_duration_fixed_array = 16; // length 3
// time fixed-length array field
repeated google.protobuf.Timestamp field_time_fixed_array = 16; // length 3
repeated google.protobuf.Timestamp field_time_fixed_array = 17; // length 3
// boolean fixed-length array field
repeated bool field_boolean_fixed_array = 17; // length 3
repeated bool field_boolean_fixed_array = 18; // length 3
// bytes fixed-length array field
repeated bytes field_bytes_fixed_array = 18; // length 3
repeated bytes field_bytes_fixed_array = 19; // length 3
// float64 fixed-length array field
repeated double field_float64_fixed_array = 19; // length 3
repeated double field_float64_fixed_array = 20; // length 3
// uint32 fixed-length array field
repeated fixed32 field_uint32_fixed_array = 20; // length 3
repeated fixed32 field_uint32_fixed_array = 21; // length 3
// string fixed-length array field
repeated string field_string_fixed_array = 21; // length 3
repeated string field_string_fixed_array = 22; // length 3
// An enum field
ExampleProtoEnum field_enum = 22;
ExampleProtoEnum field_enum = 23;
// An enum array field
repeated ExampleProtoEnum field_enum_array = 23;
repeated ExampleProtoEnum field_enum_array = 24;
// A nested field
foxglove.NestedMessage field_nested = 24;
foxglove.NestedMessage field_nested = 25;
// A nested array field
// With
// a
// very
// long
// description
repeated foxglove.NestedMessage field_nested_array = 25;
repeated foxglove.NestedMessage field_nested_array = 4;
}
"
`);
Expand Down
Loading

0 comments on commit b6b7350

Please sign in to comment.