Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

3D Beta support for Foxglove image types #4323

Closed
jtbandes opened this issue Aug 31, 2022 · 2 comments · Fixed by #4425
Closed

3D Beta support for Foxglove image types #4323

jtbandes opened this issue Aug 31, 2022 · 2 comments · Fixed by #4425
Assignees
Labels
panel: 3d three.js 3D panel

Comments

@jtbandes
Copy link
Member

jtbandes commented Aug 31, 2022

Add support for RawImage, CompressedImage, and CameraCalibration.
Blocked on foxglove/schemas#59

@defunctzombie
Copy link
Contributor

What's our plan for tying CameraCalibration to the Image messages? In ROS the typical pattern is sibling topics? Will we support and document the same? Is there another pattern that is useful to support and would we need any other fields in the messages to support such a pattern?

@jtbandes
Copy link
Member Author

The easiest solution would be to provide a setting in the sidebar so the user can choose the associated topic.

jtbandes added a commit to foxglove/schemas that referenced this issue Sep 7, 2022
**Public-Facing Changes**
Added `frame_id` to RawImage, CompressedImage, and CameraCalibration

**Description**
Closes #59 
Unblocks foxglove/studio#4323
@jtbandes jtbandes added the panel: 3d three.js 3D panel label Sep 13, 2022
@jtbandes jtbandes self-assigned this Sep 14, 2022
jtbandes added a commit that referenced this issue Sep 14, 2022
**User-Facing Changes**
Added support for Foxglove RawImage, CompressedImage, and
CameraCalibration schemas to the new 3D panel.

**Description**
Closes #4323
wimagguc added a commit that referenced this issue Sep 15, 2022
3D: support PoseInFrame and PosesInFrame (#4419)

**User-Facing Changes**
None (feature is already documented and was a regression in the new 3d
panel)

**Description**
Fixes #4417

3D: support foxglove Image types (#4425)

**User-Facing Changes**
Added support for Foxglove RawImage, CompressedImage, and
CameraCalibration schemas to the new 3D panel.

**Description**
Closes #4323
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
panel: 3d three.js 3D panel
Development

Successfully merging a pull request may close this issue.

2 participants