Move app to packages/studio-base/src

[amacneil]

There are two commits in this PR. The first one is mechanical (rename files) and can be easily recreated. The second commit contains actual code modifications.

Please keep this PR easy to rebase in the future, by amending any code changes to the second commit. Don't add additional commits.

How to rebase this PR (trash and recreate the first commit, then cherry pick the second commit):

# start from a fresh master
git status  # start with a clean local tree
git fetch
git reset --hard origin/main

# create the rename commit
mkdir -p packages/studio-base && \
git mv app packages/studio-base/src && \
git mv packages/studio-base/src/.eslintrc.yaml packages/studio-base/ && \
git mv packages/studio-base/src/*.json packages/studio-base/ && \
git mv packages/studio-base/src/webpack* packages/studio-base/ && \
git mv packages/studio-base/src/Webpack* packages/studio-base/ && \
git commit -m 'Rename files'

# cherry pick the actual code changes
git cherry-pick <sha>  # use the commit sha from the second commit in this PR
# fix any merge conflicts

[defunctzombie]

@amacneil still planning to land this?

[defunctzombie]

I made a separate PR for these changes so we can minimize the second commit diff.
#1136

[jtbandes]

Why are these changes needed now?

[amacneil]

because we want to avoid the extra src directory in imports. previously this was not needed because the paths exactly matched the folder structure