This repository has been archived by the owner on Mar 24, 2024. It is now read-only.
Expose subscribeToNewsletter as a context #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for replacing within stories and tests via context rather than out of band mocks. Remove the storybook mock and webpack alias that powered the mock.
jtbandes
reviewed
Jun 2, 2021
|
|
||
| import subscribeToNewsletter from "./subscribeToNewsletter"; | ||
|
|
||
| type SubscribeNewsletterFn = (email: string) => Promise<void> | void; |
There was a problem hiding this comment.
what's with Promise<void> | void?
There was a problem hiding this comment.
storybook action("Foo") returns a function that returns void.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for replacing within stories and tests via context rather than out of band mocks.
Remove the storybook mock and webpack alias that powered the mock.
Something with the mock was not working in #1017 so we opt for this approach to unblock 1017.