This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
add build command for browser #1524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaya Kataoka <ms.kataoka@gmail.com>
|
|
|
We've been doing this by using @amacneil should we use this instead? If yes we should probably document it on the README? |
|
I think either have both desktop and web scripts in the root package.json, or neither. If we use this approach, let’s align it with the desktop scripts (web:build:dev, web:build:prod, web:serve, etc). If that feels like too many scripts, we could just remove all these build scripts from root and keep them under appropriate desktop or web packages only? |
|
Thanks! I added the rest of the commands in #1525 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masaya Kataoka ms.kataoka@gmail.com
User-Facing Changes
I want to build website like https://studio.foxglove.dev/?, but I could not found command, so I add it.
Description
Adding build commands for building website.
How to check
please type commands below.
connect to http://localhost:8080/