This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Fix issues with disabled plot series #7342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defunctzombie
approved these changes
Jan 18, 2024
|
I’m not sure the aborting is so important - I suppose it would be the most thorough thing to do but I didn’t feel compelled. |
jtbandes
added a commit
that referenced
this pull request
Jan 22, 2024
**User-Facing Changes** Not worth calling out **Description** Fixed bugs with series that are invalid (fail to parse) causing tooltips and current values to display on a different series. (Similar to #7342 but for invalid series) Approach: instead of each builder handling its own `data: []` defaults (added in #7342), the builders use the series' `configIndex` to output `datasetsByConfigIndex`. The coordinator fills in missing entries with `data: []` before passing to the renderer. https://github.com/foxglove/studio/assets/14237/c8f6ba28-8eb9-46d8-a3cc-6b914c7aab93
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Fixed issues with disabled series in the Plot panel.
Description
PlotCoordinator.destroy()to fix an issue where switching from Timestamp to Index mode would still show the timestamp data (because the old coordinator rendered after the new one)getViewportDatasetsfor disabled seriesenabledsetting insetSeries(even if the series did not otherwise change)