This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Fix issues with invalid plot series #7356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| contrastColor: "blue", | ||
| enabled: true, | ||
| timestampMethod: "receiveTime", | ||
| key: "x" as SeriesConfigKey, |
There was a problem hiding this comment.
It is somewhat awkward that we have both a key and a config index. The key was meant to act like the identifier.
There was a problem hiding this comment.
The key does not uniquely identify series because you could have multiple series in the config with the same timestampMethod and path.
defunctzombie
approved these changes
Jan 22, 2024
jtbandes
deleted the
jacob/fg-6364-invalid-message-paths-cause-tooltip-to-display-on-wrong
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Changes
Not worth calling out
Description
Fixed bugs with series that are invalid (fail to parse) causing tooltips and current values to display on a different series. (Similar to #7342 but for invalid series)
Approach: instead of each builder handling its own
data: []defaults (added in #7342), the builders use the series'configIndexto outputdatasetsByConfigIndex. The coordinator fills in missing entries withdata: []before passing to the renderer.Screen.Recording.2024-01-19.at.4.41.55.PM.mov