Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve workflows #80

Merged
merged 3 commits into from
Jun 17, 2023
Merged

ci: improve workflows #80

merged 3 commits into from
Jun 17, 2023

Conversation

ardalanamini
Copy link
Member

@ardalanamini ardalanamini commented Jun 17, 2023

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed & coverage is same or better

ℹ️ Additional Information

Closes #64 & #20

@ardalanamini ardalanamini added enhancement New feature or request performance Issues or pull requests related to performance github actions Pull requests that update GitHub Actions code labels Jun 17, 2023
@ardalanamini ardalanamini self-assigned this Jun 17, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2023

⚠️ No Changeset found

Latest commit: c2ce594

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ardalanamini ardalanamini force-pushed the ci/improve-workflows branch 2 times, most recently from 04161c1 to 0b6483d Compare June 17, 2023 13:37
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #80 (c2ce594) into main (10b9dc6) will increase coverage by 0.14%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   84.53%   84.67%   +0.14%     
==========================================
  Files          46       46              
  Lines        1688     1684       -4     
  Branches      409      400       -9     
==========================================
- Hits         1427     1426       -1     
+ Misses        243      242       -1     
+ Partials       18       16       -2     
Flag Coverage Ξ”
config 65.00% <ΓΈ> (ΓΈ)
foxify 60.28% <ΓΈ> (ΓΈ)
fresh 100.00% <ΓΈ> (ΓΈ)
http 87.93% <76.92%> (+0.20%) ⬆️
inject 97.40% <100.00%> (ΓΈ)
router 96.92% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
packages/http/src/Response.ts 87.57% <75.00%> (+0.52%) ⬆️
packages/http/src/Request.ts 100.00% <100.00%> (ΓΈ)
packages/inject/src/index.ts 97.40% <100.00%> (ΓΈ)
packages/router/src/Router.ts 95.29% <100.00%> (+0.39%) ⬆️

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nx-cloud
Copy link

nx-cloud bot commented Jun 17, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c2ce594. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this branch


βœ… Successfully ran 3 targets

Sent with πŸ’Œ from NxCloud.

@ardalanamini ardalanamini force-pushed the ci/improve-workflows branch 18 times, most recently from 68ff3c9 to 980492f Compare June 17, 2023 18:02
Signed-off-by: Ardalan Amini <ardalanamini22@gmail.com>
Signed-off-by: Ardalan Amini <ardalanamini22@gmail.com>
Signed-off-by: Ardalan Amini <ardalanamini22@gmail.com>
@ardalanamini ardalanamini marked this pull request as ready for review June 17, 2023 19:49
@ardalanamini ardalanamini merged commit 434f9ae into main Jun 17, 2023
@ardalanamini ardalanamini deleted the ci/improve-workflows branch June 17, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github actions Pull requests that update GitHub Actions code performance Issues or pull requests related to performance
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ci: Improve CodeCov usage
1 participant