refactor: use key/value cursor for serialization, retire ring buffer #230
+76
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
BenchmarkPR100s mem 
main100s mem 
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
+ Coverage 75.45% 75.65% +0.19%
==========================================
Files 47 47
Lines 5847 5775 -72
==========================================
- Hits 4412 4369 -43
+ Misses 1435 1406 -29 ☔ View full report in Codecov by Sentry. |
|
I will review ASAP |
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Close #226 |
3 tasks
Li0k
reviewed
Dec 14, 2023
| @@ -433,7 +395,7 @@ impl std::io::Read for ArcVecU8Cursor { | |||
| let slice = self.inner.as_ref().as_slice(); | |||
| let len = std::cmp::min(slice.len() - self.pos, buf.len()); | |||
| buf.put_slice(&slice[self.pos..self.pos + len]); | |||
| self.pos -= len; | |||
| self.pos += len; | |||
There was a problem hiding this comment.
Is it a bug introduced from previous PR ?
There was a problem hiding this comment.
Yep, this PR is part of a series to make each PR small. The previous one is not fully tested.
|
Could you add some background info about this PR? |
The related issues informed some. |
This was referenced Dec 15, 2023
MrCroxx
added a commit
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
As titled.
Checklist
make checkandmake testormake allin my local envirorment.Related issues or PRs (optional)
#216
close #226