Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched travis to github-actions #149

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Conversation

junjihashimoto
Copy link
Collaborator

This is a trial to setup github actions.

@junjihashimoto junjihashimoto marked this pull request as ready for review September 24, 2023 23:59
@junjihashimoto
Copy link
Collaborator Author

@bitonic @roberth
Support 3 generations and discontinue older generations.
For now, it will only test nightly, lts-21, and lts-20.
It's okay, right?

@junjihashimoto
Copy link
Collaborator Author

The example of GSL depends on cairo package. Cairo package is not very well maintained.
To reduce maintenance cost, I am thinking of not using cairo for the GSL example and outputting only CSV.

@junjihashimoto
Copy link
Collaborator Author

BTW, this CI tests macos's version, but it supports only intel silicon.
Doesn't help with apple silicon issues.

@@ -38,3 +38,6 @@ test-suite tests
default-language: Haskell2010
if os(darwin)
frameworks: Foundation
buildable: True
else
buildable: False
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux does not have the Foundation library, so it can not be tested.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory Linux could use GNUstep, I suppose, but let's keep it simple.

@@ -94,7 +94,7 @@ solveOde
-> Either String (V.Vector Double)
-- ^ Solution at end point, or error.
solveOde fun x0 f0 xend =
coerce $ solveOdeC (coerce fun) (coerce x0) (coerce f0) (coerce xend)
unsafeCoerce $ solveOdeC (unsafeCoerce fun) (unsafeCoerce x0) (unsafeCoerce f0) (unsafeCoerce xend)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that not only instance Coercible (Vector CDouble) (Vector Double) but also instance Coercible CDouble Double are not defined.
So this update is needed.
This is related to #146 .

if [ ${{ matrix.os }} == "ubuntu-latest" ] ; then
stack build --stack-yaml stack-${{ matrix.stackage }}.yaml --flag inline-c:gsl-example --flag inline-c-cpp:std-vector-example
else
stack build --stack-yaml stack-${{ matrix.stackage }}.yaml --flag inline-c-cpp:std-vector-example
Copy link
Collaborator Author

@junjihashimoto junjihashimoto Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When macos, the compilation of gsl-example is disabled.
gsl-example throws a runtime error like conda-forge/gsl-feedstock#34 .
This is gls's issue.

@junjihashimoto junjihashimoto merged commit 91667de into master Sep 25, 2023
6 checks passed
@junjihashimoto junjihashimoto deleted the feature/github-actions branch September 25, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants