Impl Drop for Lzmawriter #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, could you merge this? i would improve the ergonomics greatly... |
|
Sorry, this project is not maintained anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented drop for the lzmawriter so that it is not mandatory to run finish().
I have unfortunately run into situations where it was no longer possible for me to execute finish(). For this purpose I have implemented what is executed in finish() in Drop. With finish(), however, the return value must then be adjusted (see pull request).
With Drop you don't get any feedback in case of an error - but you wouldn't if finish() wasn't executed.
I see no disadvantage here at the moment.