NSLoggerViewer: prevent new connections from creating multiple windows #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows. This happens in our project because the first ClientInfo message received only contains the application name and version, but not the OS details. Afterwards a second ClientInfo is received with the full metadata set, but by that time the connection has already been attached to a new window. I'm not sure if this is something we could fix in our project by initializing NSLogger differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens in our project because the first ClientInfo message received
only contains the application name and version, but not the OS details.
Afterwards a second ClientInfo is received with the full metadata set,
but by that time the connection has already been attached to a new
window.
I'm not sure if this is something we could fix in our project by
initializing NSLogger differently.