Improve default strategy path handling #512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not define FPLLL_DEFAULT_STRATEGY_PATH or FPLLL_DEFAULT_STRATEGY to the empty string (when undefined) in fplll/defs.h. This is not usable for library API users, and not needed for compiling the library.
This provides configure script options --with-default-strategy-dir and --with-default-strategy, which allow distributions that need the data directory to be in a different place to avoid patching the build system. For example, Debian might want to use --with-default-strategy-dir=/usr/share/libfplll5/strategies.
|
I like the idea of the configure flags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not define
FPLLL_DEFAULT_STRATEGY_PATHorFPLLL_DEFAULT_STRATEGYto the empty string (when undefined) in fplll/defs.h. This is not usable for library API users, and not needed for compiling the library.Allow setting the default strategy paths via new
configurescript options--with-default-strategy-dirand--with-default-strategy. This allows distributions that need the data directory to be in a different place to avoid patching the build system. For example, Debian might want to use--with-default-strategy-dir=/usr/share/libfplll5/strategies.Make the actual strategy paths compiled into the library available as variables in the
pkg-configfilefplll.pc.Fixes #510.
I have tested this by rebuilding all Fedora Linux packages that depend on
libfplll(gap-pkg-float,linbox,Macaulay2,python-fplll, andsagemath) in a COPR.I’m hoping that people who commented in fplll/fpylll#221 will review this and verify it meets their needs, or suggest any necessary improvements.