Fix disconnector use-after-free access after signal move construction #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The disconnector object is no longer stored directly in the signal object. It is now stored on the heap and managed by the shared pointer that was already present to enable weak pointers, but did not actually manage the disconnector object. fixes fr00b0#24
kevin--
approved these changes
Oct 4, 2023
| @@ -17,10 +17,8 @@ namespace nod { | |||
| /// Interface for type erasure when disconnecting slots | |||
| struct disconnector { | |||
| virtual void operator()( std::size_t index ) const = 0; | |||
| virtual ~disconnector() {} | |||
There was a problem hiding this comment.
pedantic, could use = default
Suggested change
| virtual ~disconnector() {} | |
| virtual ~disconnector() = default; |
There was a problem hiding this comment.
Agreed. I am willing to change that when/if I get feedback form the maintainer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disconnector object is no longer stored directly in the signal object. It is now stored on the heap and managed by the shared pointer that was already present to enable weak pointers, but did not actually manage the disconnector object.
fixes #24