Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that coroutines are awaited #287

Closed
tcompa opened this issue Nov 18, 2022 · 1 comment · Fixed by #535
Closed

Test that coroutines are awaited #287

tcompa opened this issue Nov 18, 2022 · 1 comment · Fixed by #535
Assignees
@ychiucco
Labels
testing testing unclear Let's check whether this is still an open issue
Milestone
enhancements backlog

Comments

@tcompa
Copy link
Collaborator

tcompa commented Nov 18, 2022 •
edited by jacopo-exact
Loading

See #286

Why wasn't it caught anywhere in the CI?
@jacopo-exact jacopo-exact added the testing testing label Nov 23, 2022
@tcompa tcompa added this to the enhancements backlog milestone Dec 20, 2022
@tcompa tcompa added the unclear Let's check whether this is still an open issue label Feb 15, 2023
ychiucco added a commit that referenced this issue Feb 23, 2023
@ychiucco
add checkawait decorator
bb4306c 
ref #286 #287
@ychiucco ychiucco mentioned this issue Feb 23, 2023
Merged
@ychiucco ychiucco linked a pull request Feb 23, 2023 that will close this issue
Catch not-awaited errors in CI #535
Merged
@tcompa tcompa changed the title Add test for #286 Test that coroutines are awaited Feb 24, 2023
@tcompa
Copy link
Collaborator Author

tcompa commented Feb 24, 2023

Refs:

tcompa added a commit that referenced this issue Feb 24, 2023
@tcompa
Add test_unit_coroutine_never_awaited.py (ref #287)
0dfe912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ychiucco ychiucco

Labels
testing testing unclear Let's check whether this is still an open issue
Projects
None yet
Milestone
enhancements backlog
Development

Successfully merging a pull request may close this issue.

Catch not-awaited errors in CI fractal-analytics-platform/fractal-server
3 participants
@tcompa @ychiucco @jacopo-exact