Add ability to get mysql password from file #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fradelg
reviewed
Jan 8, 2022
backup.sh
Outdated
| then | ||
| echo "==> Dumping database: $db" | ||
| FILENAME=/backup/$DATE.$db.sql | ||
| LATEST=/backup/latest.$db.sql.gz | ||
| if mysqldump --single-transaction -h "$MYSQL_HOST" -P "$MYSQL_PORT" -u "$MYSQL_USER" -p"$MYSQL_PASS" "$db" $MYSQLDUMP_OPTS > "$FILENAME" | ||
| if mysqldump --single-transaction -h "$MYSQL_HOST" -P "$MYSQL_PORT" -u "$MYSQL_USER" -p"$MYSQL_PASS" "$db" "$MYSQLDUMP_OPTS" > "$FILENAME" |
There was a problem hiding this comment.
I think MYSQLDUMP_OPTS may include double quotes and this will break some cases. Can you leave it unquoted as it was before?
|
Hi! Thank you for your contribution. If you can address my comment I will be happy to merge your PR with master |
|
Sorry for the delay. Shall be OK now. |
|
No worries, thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
To avoid putting cleartext password in docker-compose file, use the facility to put the password in a file, as used by docker secrets.
The file path is to be set set in MYSQL_PASS_FILE.
In case of use in docker secret, path shall be /run/secrets/my_docker_secret_name
Regards.