Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugins system #62

Merged
merged 16 commits into from
Oct 16, 2021
Merged

Add plugins system #62

merged 16 commits into from
Oct 16, 2021

Conversation

arctic-hen7
Copy link
Member

@arctic-hen7 arctic-hen7 commented Oct 13, 2021

This adds support for functional and control plugins, albeit with a limited number of actions right now. This doesn't yet include support for CLI instructions, that will come in future (but very likely before v0.3.0). This is missing support for extending Actix Web server configuration due to certain typing/compilation issues with that library, though there's a workaround of a simple replacement character at present, which could be set by functional or control plugins, which is all documented (or rather will be).

As a side note, this does not add support for custom engines (formerly known as type 3 plugins).

Closes #58.

@arctic-hen7 arctic-hen7 added A-plugins Area: plugins system C-enhancement Category: enhancement P-medium Priority: medium S-in-development Status: in development labels Oct 13, 2021
@arctic-hen7 arctic-hen7 self-assigned this Oct 13, 2021
We can't modify `MutableStore` or `TranslationsManager` yet though.

BREAKING CHANGE: `build_app`/`export_app`now take a `&TemplateMap` (`get_templates_vec` abolished)
Note that `PluginData` is now replaced by `Any`.
This is just a change to the version number, but nonetheless needed before we merge this branch back.
Any plugin can now take functional or control actions. Docs still need updating.
These are replaced by the `set_immutable_store` settings action
@arctic-hen7
Copy link
Member Author

I'll add the new testing workflow for the plugins example after this is merged.

@arctic-hen7 arctic-hen7 marked this pull request as ready for review October 16, 2021 01:32
@arctic-hen7 arctic-hen7 merged commit ca0aaa2 into main Oct 16, 2021
@arctic-hen7 arctic-hen7 deleted the feat-plugins branch October 16, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-plugins Area: plugins system C-enhancement Category: enhancement P-medium Priority: medium S-in-development Status: in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins
1 participant