Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overflow #67

Merged
merged 7 commits into from
May 2, 2021
Merged

Allow overflow #67

merged 7 commits into from
May 2, 2021

Conversation

Brod8362
Copy link
Contributor

@Brod8362 Brod8362 commented Feb 12, 2021

Allows values to go over maximum with the flag -f, --allow-overflow. This will cause the bar to wrap around and display in a color defined by --overflow-color (default is red, #FFFF0000).

Mentioned in issues #22 and #54.

Normal operation:
normal

Overflow (with color set to green):
overflow

@Brod8362
Copy link
Contributor Author

The archlinux and freebsd tests are failing, doesn't seem to be related to the code though.

@YerinAlexey
Copy link

Maybe instead of trying to display what's above the overflow you can just fill the bar 100% and set color to overflow-color. Or at least have this as an option?

@Brod8362
Copy link
Contributor Author

Added that as --no-wrap. The default behavior is to wrap around, and if --no-wrap is set it will simply display at 100% in the color specified by --overflow-color

@YerinAlexey
Copy link

Cool!

@CromFr
Copy link

CromFr commented Mar 8, 2021

I'm daily driving this PR, it works very well and is very handy for pulseaudio volume feedback 👍

main.c Outdated Show resolved Hide resolved
main.c Outdated Show resolved Hide resolved
main.c Outdated Show resolved Hide resolved
@francma
Copy link
Owner

francma commented Mar 8, 2021

Thank you for this MR. I have fixed the Archlinux CI - should be passing now after rebase.

Also please squash commits into single one.

@nichobi
Copy link

nichobi commented Mar 9, 2021

Also please squash commits into single one.

Maybe you already know this and have a reason not to, but just wanted to mention that you can squash the commits yourself when merging (see github docs, step 3).

@Brod8362 Brod8362 requested a review from francma March 14, 2021 19:21
@Brod8362
Copy link
Contributor Author

Brod8362 commented Mar 14, 2021

Everything finished.
The formatter appears to have taken some... creative liberties around line 557 in main.c.

I can squash the commits if you want me to, but it would probably be tidier to squash it yourself when merging as per @nichobi's comment.

@Brod8362
Copy link
Contributor Author

Brod8362 commented May 2, 2021

Any updates on this?

@francma francma merged commit aec2abb into francma:master May 2, 2021
@francma
Copy link
Owner

francma commented May 2, 2021

Sorry for the delay, I've been busy lately 🙁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants