-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overflow #67
Allow overflow #67
Conversation
The archlinux and freebsd tests are failing, doesn't seem to be related to the code though. |
Maybe instead of trying to display what's above the overflow you can just fill the bar 100% and set color to |
Added that as |
Cool! |
I'm daily driving this PR, it works very well and is very handy for pulseaudio volume feedback 👍 |
Thank you for this MR. I have fixed the Archlinux CI - should be passing now after rebase. Also please squash commits into single one. |
Maybe you already know this and have a reason not to, but just wanted to mention that you can squash the commits yourself when merging (see github docs, step 3). |
Everything finished. I can squash the commits if you want me to, but it would probably be tidier to squash it yourself when merging as per @nichobi's comment. |
Any updates on this? |
Sorry for the delay, I've been busy lately 🙁 |
Allows values to go over maximum with the flag
-f, --allow-overflow
. This will cause the bar to wrap around and display in a color defined by--overflow-color
(default is red,#FFFF0000
).Mentioned in issues #22 and #54.
Normal operation:
Overflow (with color set to green):