Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make SUPPORTED_FORMATS part of options #7

Closed
karimhossenbux opened this issue May 15, 2017 · 4 comments
Closed

make SUPPORTED_FORMATS part of options #7

karimhossenbux opened this issue May 15, 2017 · 4 comments
Labels
Type: Bug

Comments

@karimhossenbux
Copy link

It would be awesome if we could set SUPPORTED_FORMATS as we need.

Right now medium-zoom is enable on some SVG icons I have even if I target img tag:
mediumZoom(document.querySelectorAll('.content img'))

Let me know what you think?

Cheers!
@francoischalifour
Copy link
Owner

That's interesting, thanks for pointing that out!

Can you please share your HTML template?

@karimhossenbux
Copy link
Author

karimhossenbux commented May 17, 2017 •
edited
Loading

Actually I've been able to fix that by targeting the parent container (where there is no svg), and not the img tag itself.
I'll try to make more test once back on that project!

@E-VANCE E-VANCE mentioned this issue May 26, 2017
Closed
@francoischalifour
Copy link
Owner

Hi @karimhossenbux, a similar issue was raised #8.

It is indeed a bug and I will publish a fix very soon (#8 (comment)).

Thank you again 😄

francoischalifour added a commit that referenced this issue May 31, 2017
@francoischalifour
Fix default behavior
aa8ff0f 
`SUPPORTED_FORMATS` is now only applied when the plugin is given no selector (#7).

Handle NodeLists, HTMLCollections and Nodes better. Remove default
support for SVG tags that don't support `naturalWidth` (#8).
@francoischalifour
Copy link
Owner

Closing for now as it should be fixed with aa8ff0f.

Please upgrade to 1.0.4 and let me know if you have other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karimhossenbux @francoischalifour