Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not use window outside main function (close #94) #95

Merged
merged 1 commit into from
Mar 21, 2019
Merged

fix: do not use window outside main function (close #94) #95

merged 1 commit into from
Mar 21, 2019

Conversation

meteorlxy
Copy link
Contributor

Summary

Related to #94

  • move const Promise = ... into mediumZoom() to avoid accessing window immediately

francoischalifour
francoischalifour approved these changes Mar 21, 2019
View reviewed changes
Copy link
Owner

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@francoischalifour francoischalifour merged commit 541e8f0 into francoischalifour:master Mar 21, 2019
@meteorlxy meteorlxy deleted the fix/94 branch April 4, 2019 06:20
@meteorlxy
Copy link
Contributor Author

@francoischalifour Hello, when will the next version be released? This fix is not complicated, but I think a patch version is OK for this fix 😄 .

@francoischalifour
Copy link
Owner

I'll release a patch this weekend.

@meteorlxy
Copy link
Contributor Author

Thanks!

@francoischalifour
Copy link
Owner

Released in 1.0.4.

@snyk-bot snyk-bot mentioned this pull request Mar 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoischalifour francoischalifour francoischalifour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorlxy @francoischalifour