React - Fix missing server url params & query #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frandiox
approved these changes
Apr 3, 2021
There was a problem hiding this comment.
@huygn Thank you for taking the time to fix this!
Looks like there's still an issue with the parameters. It works on first rendering (SSR) but doesn't work when changing routes afterwards (in SPA take-over).
I've released a new version of vite-ssr addressing this problem (code here) and now the to route should contain the correct path, params, etc. I'm going to merge this and fix it in master branch 👍
|
@huygn Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react/utilsCurrently there is no route params received on props
handlerfunction, those matched params can be found in thematchproperty ofmatchRoutes.react/entry-clientPrior to this it was sending route's
pathtofetchmethod .eg you'll see/post/:postIdon the network tab instead of/post/1and thus causing a wrong props fetch, this tries to fix that behavior by usingwindow.location's pathname & search query.example/reactupdated the example for the sake of demonstration (
/post/:postId) path.