Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrency race when running in parallel #99

Closed
xpzouying opened this issue Jan 13, 2021 · 0 comments
Closed

Concurrency race when running in parallel #99

xpzouying opened this issue Jan 13, 2021 · 0 comments

Comments

@xpzouying
Copy link
Contributor

As PR #98 Says, concurrency race panic when running in parallel.

parseFlag() function only need do once, so use sync.Once to do init things.
xpzouying added a commit to xpzouying/goblin that referenced this issue Jan 13, 2021
@xpzouying
fix: Concurrency race when running in parallel
0fa95e6 
Use sync.Once to init flag variables.

fix: franela#98 franela#99
@xpzouying xpzouying mentioned this issue Jan 13, 2021
Merged
marcosnils pushed a commit that referenced this issue Jan 13, 2021
@xpzouying
fix: Concurrency race when running in parallel (#100)
9427430 
* fix: Concurrency race when running in parallel

Use sync.Once to init flag variables.

fix: #98 #99

* fix: data race when concurrence to create Goblin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcosnils @xpzouying