-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Xit() to Exclude Test #62
Conversation
updating readme to reflect new xit feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment in tests, otherwise LGTM!.
goblin_test.go
Outdated
|
||
}) | ||
|
||
if fakeTest.Failed() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to also assert that count
is still 0 in the end.
including check for not 0
Good idea. Added an extra check for making sure count is not altered. |
Thanks a lot for the contribution @dan9186 . We'll move the images to static hosting soon :) |
Why was |
With a conversation already existing where the project owner expressed acceptance of |
Those reasons make sense! Thanks for the explanation. Already using this feature 👌 . Thanks! |
I saw issue #56 has been around for a while with the comment of not having time to add it, and noticed #60 came up recently. Thought I would take a stab at adding it.
Itable
interface for variations ofIt
Xit
struct and methodsYellow
fancier for excluded outputs