Feat/webcam Add web player for monitor #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add monitor event to shapes, use xgplayer to play live media ,such like http-flv,mp4 .
add monitor event to shapes, use xgplayer to play live media ,such like http-flv,mp4 .
add monitor event to shapes, use xgplayer to play live media ,such like http-flv,mp4 .
|
Hi, Amazing, I love it. |
unocelli
requested changes
Mar 10, 2024
There was a problem hiding this comment.
Thank you for your pull request! Overall, it looks great. One small suggestion I have is regarding the use of double quotes instead of single quotes in some parts of the code. It's a good practice to consistently use single quotes for string literals in JavaScript.
xgplayer compatibility is better， and http-flv format is popular for live media. xgplayer belong to the bytedance who devlope tiktok , by the way . |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add monitor event to shapes, use xgplayer to play live media ,such like http-flv,mp4 .
add a shape with new monitor event
when click shapes show dialog
tested media