CHANGE: Remove namespace from franka_gazebo launch file
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2021
gollth
force-pushed
the
fix/no-namespace
branch
from
672bffb
to
f1197b0
Compare
gollth
approved these changes
Nov 10, 2021
gollth
added a commit
that referenced
this pull request
Jul 28, 2022
* commit '249c593c8ff4d3f476dd74d5e7bfbf67d0a9d206': (22 commits) ADD: Integration test verifying that user stops stops joint in Gazebo ADD: Make interactive marker configurable in `panda.launch` FIX: Allow finger joints to still be controlled while not in Move FIX: Don't stop finger joints on error recovery FIX: ROS_WARN message on user stop FIX: Don't recovery from errors when user stop still pressed ADD: CHANGELOG entry FIX: Make linter happy ADD: Statemachine tests ADD: Warning to FrankaHWSim::error_recovery action CHANGE: Restart all running controllers on error_recovery CHANGE: Extract `getDesiredXXX()` logic into Joint class FIX: Don't switch control method on user stop ADD: `error_recovery` action to FrankaHWSim CHANGE: Extract motion generators into separate functions CHANGE: Set `control_method` in statemachine actions ADD: FrankaHWSim offers `set_user_stop` service ADD: Allow position control for prismatic joints CHANGE: Properly distinguish between Position & Internal control ADD: Control state machine to franka_gazebo ...
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Sep 3, 2023
This commit removes the robot namespace warning found in the FrankaHWSim since it is no longer needed now that frankaemika#196 has been merged. It also replaced the 'arm_id' default with the model name.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Sep 3, 2023
This commit removes the robot namespace warning found in the FrankaHWSim since it is no longer needed now that frankaemika#196 has been merged. It also replaced the 'arm_id' default with the model name.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Sep 3, 2023
This commit removes the robot namespace warning found in the FrankaHWSim since it is no longer needed now that frankaemika#196 has been merged. It also replaced the 'arm_id' default with the model name.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Sep 4, 2023
This commit removes the robot namespace warning found in the FrankaHWSim since it is no longer needed now that frankaemika#196 has been merged. It also replaced the 'arm_id' default with the model name.
rickstaa
added a commit
to rickstaa/franka_ros
that referenced
this pull request
Mar 23, 2024
This commit removes the robot namespace warning found in the FrankaHWSim since it is no longer needed now that frankaemika#196 has been merged. It also replaced the 'arm_id' default with the model name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples the
arm_idfrom the ROS namespace used by the spawned robot. The namespace isn't specified via the URDF file anymore, which was awkward, but the usual way. For example, one could spawn to robots into the same Gazebo instance:That's a great replacement for #187.