Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent initializes by existing iframe #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aiji42
Copy link

@aiji42 aiji42 commented Dec 28, 2020

Issue

#4

What I did.

  • updated src/Parent.ts
    • Changed the argument type to Union.
      • type IConstructorArgs = IConstructorByUrlArgs | IConstructorByElementArgs;
    • Changed to initialize by conditional branching from argument types.
      • This is verbose, so it may be better to split it into several functions.
  • created examples/parentExistingIframe.html

What I didn't do.

  • No change src/index.test.ts / src/integration.test.ts.
  • The README has not been changed.
    • I will respond if changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant