Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

fill in default github environment variables #9

Closed
frantjc opened this issue Dec 11, 2021 · 3 comments
Closed

fill in default github environment variables #9

frantjc opened this issue Dec 11, 2021 · 3 comments
Assignees

Comments

@frantjc
Copy link
Owner

frantjc commented Dec 11, 2021

the sequence cli should try to parse information from the .git and .github/ folders in the current directory to fill in the default environment variables that github actions supplies: https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables

such variables should be overridable on all sqnc run commands via flags

@frantjc frantjc added the enhancement New feature or request label Dec 11, 2021
@frantjc frantjc self-assigned this Jan 13, 2022
@frantjc
Copy link
Owner Author

frantjc commented Jan 13, 2022

looking like some of the environment variables are not going to be able to be parsed locally; we should be able to call out to GitHub's API to try and retrieve some

the primary problematic one will be GITHUB_TOKEN. ideally we can prompt the user for credentials and then call out to GitHub for it, but we should also allow the user to override it.

@frantjc frantjc removed the enhancement New feature or request label Jan 13, 2022
@frantjc
Copy link
Owner Author

frantjc commented Jan 21, 2022

@moeller142 this is the issue for what we were just talking about (getting GitHub env vars from CLI, remote, .git dir, etc

@moeller142 moeller142 self-assigned this Jan 21, 2022
@frantjc
Copy link
Owner Author

frantjc commented Mar 26, 2022

pretty sure everything gets filled in from local git repositories now except head ref and base ref. need to be able to do the same from remote repositories for sequence to be able to scale

@frantjc frantjc closed this as completed Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants