Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some Compiler Warnings to prepare for Pedantic Mode #99

Merged

Conversation

franziska-wegner
Copy link
Owner

This PR is part of the warning awareness week as we soon will switch to pedantic compilation mode to avoid unnecessary conflicts for all developers from the "beginning".

@franziska-wegner franziska-wegner self-assigned this Jan 5, 2024
@franziska-wegner franziska-wegner added the enhancement New feature or request label Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e48b3be) 94.57% compared to head (2556df8) 94.57%.

Files Patch % Lines
...DataStructures/Container/TestMappingBinaryHeap.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files          55       55           
  Lines        5049     5049           
=======================================
  Hits         4775     4775           
  Misses        274      274           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franziska-wegner franziska-wegner merged commit 48126bc into main Jan 6, 2024
16 of 17 checks passed
@franziska-wegner franziska-wegner deleted the franziska-wegner/2024/january/remove-warnings-02 branch January 6, 2024 09:58
github-actions bot added a commit that referenced this pull request Jan 6, 2024
* Remove modernize-use-trailing-return-type warning in main
* Remove modernize-use-equals-default warning in TestBound
* Remove modernize-use-trailing-return-type warning in TestMappingBinaryHeap
* Add const in TestPowerGrid
* Formatting issues with const in Color.hpp 48126bc
github-actions bot added a commit that referenced this pull request Jan 6, 2024
* Remove modernize-use-trailing-return-type warning in main
* Remove modernize-use-equals-default warning in TestBound
* Remove modernize-use-trailing-return-type warning in TestMappingBinaryHeap
* Add const in TestPowerGrid
* Formatting issues with const in Color.hpp 48126bc
github-actions bot added a commit that referenced this pull request Jan 6, 2024
* Remove modernize-use-trailing-return-type warning in main
* Remove modernize-use-equals-default warning in TestBound
* Remove modernize-use-trailing-return-type warning in TestMappingBinaryHeap
* Add const in TestPowerGrid
* Formatting issues with const in Color.hpp 48126bc
github-actions bot added a commit that referenced this pull request Jan 6, 2024
* Remove modernize-use-trailing-return-type warning in main
* Remove modernize-use-equals-default warning in TestBound
* Remove modernize-use-trailing-return-type warning in TestMappingBinaryHeap
* Add const in TestPowerGrid
* Formatting issues with const in Color.hpp 48126bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

1 participant