-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add README #1
Comments
2 tasks
2 tasks
1 task
gavindsouza
added a commit
that referenced
this issue
Jul 27, 2022
The implementations so far were hacks that worked for the most used commands but broken down when challenged or expected to maintain documented usages [eg: custom app commands]. The current implementation consists of a two step approach: 1. figure out command name that user is trying to execute 2. pass the directive to the app (bench, frappe or other) that consists of the cmd --- For tackling #1, get_cmd_from_sysargv contains exhaustive rules that cover all (that i know and ive come across) combinations of valid frappe commands. For problem #2, a simple check in click's Group object does the trick. Tested with possible known commands with combinations of context flags and params, with bench, frappe & external app's commands
This was referenced Jan 16, 2023
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: