fix: process SSH git URLs #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC this used to work before, I almost exclusively use ssh URLs for all the apps. Not sure what broke it. |
|
@ankush, I think the rework branched out the logic for processing git URLs, which is good design, but the SSH side wasn't setup at this place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to run the following command:
bench get-app git@github.com:org/repo.gitwould result in the URL being transformed tohttps://github.com/git@github.com:org/repo.git, which errors out andget-appfails.Alternatives:
This isn't the best way to handle this, and we could use something like giturlparse. But I didn't want to add a dependency right now without getting some feedback.