Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Chart of Accounts (France) #666

Closed
Nahiiko opened this issue Jun 20, 2023 · 4 comments
Closed

Wrong Chart of Accounts (France) #666

Nahiiko opened this issue Jun 20, 2023 · 4 comments
Labels
regional Request or issue that take into account region specific requirements.

Comments

@Nahiiko
Copy link
Contributor

Nahiiko commented Jun 20, 2023

Hello,

The Chart of Accounts for France is wrong, we can use the one used by ERPNext which is correct
(github path from one I searched for quickly is erpnext/accounts/doctype/account/chart_of_accounts/verified/fr_plan_comptable_general_avec_code.json)

I think this is a very quick fix and could help many people, thank you !
(Also it could be nice to have a chart of accounts importer, but I guess that's another discussion)

Edit:
Seems like there IS in fact an importer, but I get an error when trying to import, because the links do not exist yet, example (this is not the complete table, just to let you understand the error)

name of account,parent account
account1,null
account2,account1

When importing this, since account1 doesn't exist yet in the table, the link to account1 in the second row errors. Since charts of account rely on being trees, this is a big issue.

Anyway, this is not the purpose for this github issue (which is to just replace the french chart of accounts with the correct one, including numbers too) but I think it would be good to fix this too.

@Nahiiko
Copy link
Contributor Author

Nahiiko commented Jun 23, 2023

@mael-chouteau Just saw the earlier version was from you, do you agree with my remark ? Or am I missing something ?

@mael-chouteau
Copy link
Contributor

mael-chouteau commented Jun 23, 2023

Hi @Nahiiko in didn't check the following updates to the app, do you want me to go back and make the corrections to the new import function or do you speak french ? Let me know 😁.

@Nahiiko
Copy link
Contributor Author

Nahiiko commented Jun 23, 2023

Hi @Nahiiko in didn't check the following updates to the app, do you want me to go back and make the corrections to the new import function or do you speak french ? Let me know 😁.

Well I did already submit a PR #669 , I do speak french, that's why I'm quite sure the Plan Comptable is incorrect, but maybe I missed something and I'm wrong

@mael-chouteau
Copy link
Contributor

Ok no problem thanks 👍.

@18alantom 18alantom added the regional Request or issue that take into account region specific requirements. label Jun 26, 2023
18alantom added a commit that referenced this issue Jun 26, 2023
Fix #666 : correction of french chart of accounts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regional Request or issue that take into account region specific requirements.
Projects
None yet
Development

No branches or pull requests

3 participants