Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use vite #663

Merged
merged 20 commits into from
Jun 26, 2023
Merged

build: use vite #663

merged 20 commits into from
Jun 26, 2023

Conversation

18alantom
Copy link
Member

@18alantom 18alantom commented Jun 14, 2023

PR Does a bunch of things.

  1. Gets rid of webpack based plugin to build and dev the app.
  2. Switches to using vite to build and serve the renderer process build and dev.
  3. Switches to using esbuild to build and serve the main process build and dev.
  4. Uses custom scripts to build and dev the app.
  5. Enables a bunch of eslint rules for typescript and vue.
  6. Refactors a lot of code to satisfy eslint rules and work with new build tooling.

Still a w.i.p, might do more.

- fix image path for empty list
- Table fields are only used on CommonForms anyways
- Causes circular import
- enable source maps for main process
- run main and build process using the same command
- change dev command to `yarn dev`
- disable security warnings in dev (cause by http vite server)
- add a build script (wip not yet packaged)
- remove vue-cli-plugin-electron-builder
- add code mirror dependencies to silence warning
- bump node version to allow execa
- refactor code to satisfy rules (batch 1)
- use ensuredir in build to prevent ENOENT
- update files to ignore
- delete babel.config.js
- fix filter issue in List.vue
- update readme with inspect notes
- fix log_creds.txt path for dev
- fix linting errors in the rest of the files
@18alantom 18alantom marked this pull request as ready for review June 26, 2023 08:24
@18alantom
Copy link
Member Author

Linting has been disabled for src/components/**/*.vue these will be incrementally linted, there were around 2.4k linting issues which I don't have the time to comb through right now.

So will be merging this.

@18alantom 18alantom merged commit 5f2cef7 into master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant