Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regional schema for Switzerland #769

Merged

Conversation

digitalentity
Copy link
Contributor

Fixes #768, allowes to specify Tax ID (VAT number) if country is Switzerland, propagates the taxId attribute to print object to be usable in the print templates.

Copy link
Contributor

@mildred mildred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this might be useful for more than just Swizerland in the end. Probaby all EU countries

Comment on lines 12 to 19
"quickEditFields": [
"fullname",
"email",
"companyName",
"country",
"currency",
"fiscalYearStart",
"fiscalYearEnd",
"taxId"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this list should be compared to

"quickEditFields": [
"fullname",
"email",
"companyName",
"country",
"fiscalYearStart",
"fiscalYearEnd"
]

I suppose the field currency was copied from the Indian regional schema. Does it makes sense for Swizerland?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While CHF is the national currency in Switzerland it is not uncommon for accounting to be done in EUR, especially if this is a company selling services in EU.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is intentional, no problem, I supposed something like this. But if this was just copy and paste from Indian regional schema, perhaps this did not need to be included.

@digitalentity
Copy link
Contributor Author

EU is a bit more complicated, but EU countries may benefit from a shared regional schema, but that schema will likely be different than Swiss (VAT numbers are not the same format).

@mildred
Copy link
Contributor

mildred commented Nov 28, 2023

Can you run the linter over the sources files, and perhaps remove the currency quick edit field?

Files needing linting:

[warn] schemas/regional/ch/AccountingSettings.json
[warn] schemas/regional/index.ts

command to run:

npx prettier -w schemas

@digitalentity
Copy link
Contributor Author

Done, also squashed the commits

@mildred mildred merged commit f946ce8 into frappe:master Dec 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tax ID (VAT) not available for Switzerland
2 participants