-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regional schema for Switzerland #769
Add regional schema for Switzerland #769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this might be useful for more than just Swizerland in the end. Probaby all EU countries
"quickEditFields": [ | ||
"fullname", | ||
"email", | ||
"companyName", | ||
"country", | ||
"currency", | ||
"fiscalYearStart", | ||
"fiscalYearEnd", | ||
"taxId" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this list should be compared to
books/schemas/app/AccountingSettings.json
Lines 125 to 132 in 8bf0a5f
"quickEditFields": [ | |
"fullname", | |
"email", | |
"companyName", | |
"country", | |
"fiscalYearStart", | |
"fiscalYearEnd" | |
] |
I suppose the field currency
was copied from the Indian regional schema. Does it makes sense for Swizerland?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While CHF is the national currency in Switzerland it is not uncommon for accounting to be done in EUR, especially if this is a company selling services in EU.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is intentional, no problem, I supposed something like this. But if this was just copy and paste from Indian regional schema, perhaps this did not need to be included.
EU is a bit more complicated, but EU countries may benefit from a shared regional schema, but that schema will likely be different than Swiss (VAT numbers are not the same format). |
Can you run the linter over the sources files, and perhaps remove the Files needing linting:
command to run:
|
73c4035
to
6ec7a1b
Compare
Done, also squashed the commits |
Fixes #768, allowes to specify Tax ID (VAT number) if country is
Switzerland
, propagates thetaxId
attribute to print object to be usable in the print templates.